From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 03 May 2024 14:06:25 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1s2rgG-00HHPj-3C for lore@lore.pengutronix.de; Fri, 03 May 2024 14:06:25 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1s2rgG-0001Ua-Hv; Fri, 03 May 2024 14:06:24 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s2rgB-0001UK-UE; Fri, 03 May 2024 14:06:19 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s2rgB-00FhMd-HI; Fri, 03 May 2024 14:06:19 +0200 Received: from mol by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1s2rgB-009LJQ-1T; Fri, 03 May 2024 14:06:19 +0200 Date: Fri, 3 May 2024 14:06:19 +0200 From: Michael Olbrich To: distrokit@pengutronix.de, Ahmad Fatoum Message-ID: Mail-Followup-To: distrokit@pengutronix.de, Ahmad Fatoum References: <20240503105844.2621419-1-m.olbrich@pengutronix.de> <20240503105844.2621419-3-m.olbrich@pengutronix.de> <20240503-spotty-pesticide-f533094e5e02@thorsis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240503-spotty-pesticide-f533094e5e02@thorsis.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [DistroKit] [PATCH 2/3] tf-a-stm32mp13: use _URL and _SOURCE from tf-a X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Fri, May 03, 2024 at 01:53:30PM +0200, Alexander Dahl wrote: > Hei hei, > > Am Fri, May 03, 2024 at 12:58:43PM +0200 schrieb Michael Olbrich: > > It's already the same source since version and md5 a shared. So make > > sure the exact same file is used and downloaded only once. > > > > Signed-off-by: Michael Olbrich > > --- > > configs/platform-v7a/rules/tf-a-stm32mp13.make | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/configs/platform-v7a/rules/tf-a-stm32mp13.make b/configs/platform-v7a/rules/tf-a-stm32mp13.make > > index d8a7e92de073..137dc8de3204 100644 > > --- a/configs/platform-v7a/rules/tf-a-stm32mp13.make > > +++ b/configs/platform-v7a/rules/tf-a-stm32mp13.make > > @@ -19,8 +19,8 @@ TF_A_STM32MP13_VERSION := $(call ptx/config-version, PTXCONF_TF_A) > > TF_A_STM32MP13_MD5 := $(call ptx/config-md5, PTXCONF_TF_A) > > TF_A_STM32MP13 := tf-a-stm32mp13-$(TF_A_STM32MP13_VERSION) > > TF_A_STM32MP13_SUFFIX := tar.gz > > -TF_A_STM32MP13_URL := https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/snapshot/$(TF_A_STM32MP13_VERSION).$(TF_A_STM32MP13_SUFFIX) > > -TF_A_STM32MP13_SOURCE := $(SRCDIR)/$(TF_A_STM32MP13).$(TF_A_STM32MP13_SUFFIX) > > +TF_A_STM32MP13_URL = $(TF_A_URL) > > +TF_A_STM32MP13_SOURCE = $(TF_A_SOURCE) > > As stated before: this does only work if TF_A is enabled in > platformconfig. It will still break if TF_A_STM32MP13 is enabled, but TF_A > is not. (This was already broken in that way before this change.) But the tf-a version use also reused, so it already breaks right now. This is nothing new. We should either share it all on nothing. Michael > > Greets > Alex > > > TF_A_STM32MP13_DIR := $(BUILDDIR)/$(TF_A_STM32MP13) > > TF_A_STM32MP13_BUILDDIR := $(TF_A_STM32MP13_DIR)/build > > TF_A_STM32MP13_BUILD_OOT := YES > > -- > > 2.39.2 > > > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |