From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 01 Feb 2024 09:00:49 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rVS08-00FIa9-0G for lore@lore.pengutronix.de; Thu, 01 Feb 2024 09:00:49 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rVS08-0007dM-RU; Thu, 01 Feb 2024 09:00:48 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rVS02-0007ci-CZ; Thu, 01 Feb 2024 09:00:42 +0100 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rVS02-003o65-01; Thu, 01 Feb 2024 09:00:42 +0100 Received: from mol by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rVS01-006v9w-2x; Thu, 01 Feb 2024 09:00:41 +0100 Date: Thu, 1 Feb 2024 09:00:41 +0100 From: Michael Olbrich To: Lucas Stach Message-ID: Mail-Followup-To: Lucas Stach , Robert Schwebel , Marc Kleine-Budde , distrokit@pengutronix.de, Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= References: <20240126170432.740899-1-m.olbrich@pengutronix.de> <20240126184034.GA176585@pengutronix.de> <20240127105848.GC176585@pengutronix.de> <2240a8b0ba51dd4750bafb4317615f9ec4220ee6.camel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2240a8b0ba51dd4750bafb4317615f9ec4220ee6.camel@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [DistroKit] [PATCH v4] platform-v8a: kernelconfig: cleanup X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , distrokit@pengutronix.de, Marc Kleine-Budde Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Mon, Jan 29, 2024 at 12:53:18PM +0100, Lucas Stach wrote: > Am Montag, dem 29.01.2024 um 09:38 +0100 schrieb Michael Olbrich: > > Hi, > > > > On Sat, Jan 27, 2024 at 11:58:48AM +0100, Robert Schwebel wrote: > > > On Fri, Jan 26, 2024 at 07:40:34PM +0100, Robert Schwebel wrote: > > > > Thanks, applied to next. > > > > > > The testsuite found two issues: > > > > > > - CONFIG_COMPACTION: You switched this off, but 'reason' claims that it > > > should be on, and the help test for the option does also suggest that > > > we better enable this. All of our other kernel configs for other > > > platforms have it enabled. > > > > Lucas, Marc, I don't remember why we disabled this. Unless you know and > > have a good reason, I'd say enable it. > > > There is no good reason, we simply didn't look close enough. The > reasoning was that only MIGRATION is required for CMA, but we clearly > failed to consider the Kconfig help text when disabling COMPACTION. Thanks. In that case, I think the config in next looks good now. Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |