From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 10 Jan 2025 08:38:15 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tW9aw-000HXQ-31 for lore@lore.pengutronix.de; Fri, 10 Jan 2025 08:38:15 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1tW9ax-0004pH-3w; Fri, 10 Jan 2025 08:38:15 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tW9as-0004oZ-1N; Fri, 10 Jan 2025 08:38:10 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tW9ar-0007X6-2l; Fri, 10 Jan 2025 08:38:09 +0100 Received: from mol by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1tW9ar-001r5G-2U; Fri, 10 Jan 2025 08:38:09 +0100 Date: Fri, 10 Jan 2025 08:38:09 +0100 From: Michael Olbrich To: Roland Hieber Message-ID: Mail-Followup-To: Roland Hieber , Ahmad Fatoum , distrokit@pengutronix.de References: <20241217082537.2997146-1-a.fatoum@pengutronix.de> <20250107111933.765ms7mizuvt5q6w@pengutronix.de> <20250107134559.usqg5da74op7b645@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250107134559.usqg5da74op7b645@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-IRC: #ptxdist @freenode Subject: Re: [DistroKit] [PATCH] tf-a: add current hash of v2.12 archive from Github X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: distrokit@pengutronix.de, Ahmad Fatoum Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Tue, Jan 07, 2025 at 02:45:59PM +0100, Roland Hieber wrote: > On Tue, Jan 07, 2025 at 12:30:47PM +0100, Ahmad Fatoum wrote: > > On 07.01.25 12:19, Roland Hieber wrote: > > > On Tue, Dec 17, 2024 at 09:25:37AM +0100, Ahmad Fatoum wrote: > > >> Downloading the current release manually with: > > >> > > >> curl -L 'https://github.com/ARM-software/arm-trusted-firmware/archive/refs/tags/v2.12.tar.gz' | md5sum > > >> > > >> confirms that the hash has changed: > > >> > > >> 5b90a1c21210702e64234a2beb79f23a - > > >> > > >> I am unsure why, but to fix build breakage, let's list both hashes as > > >> after extraction of both archives, the contents were found to be > > >> completely identical. > > > > > > Have you tried diffoscope? I don't have the old tarball, but sometimes the date > > > in the tar header differs when archives are re-packed by git. > > > > Good idea. I was lucky and still had the old tarball lying around. > > > > The difference is that the old tarball had a top-level directory > > named trusted-firmware-a-2.12 and the old one calls it > > arm-trusted-firmware-2.12. > > > > I am not sure what caused this rename, but apparently PTXdist > > doesn't mind what the top-level directory is called when extracting. > > Ah! git-archive is smart and sets the date in the tarball header to the date of > the commitish from which it builds the tarball, and thus produces reproducable > tarballs. But it takes the first folder part from the name of the git > repository, and in DistroKit commit 3e11c53d98c0b (2024-04-24, "tf-a: Change > download URL") the download URL was changed from > "https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git" to the current > "https://github.com/ARM-software/arm-trusted-firmware/", which changed that > name. > > PTXdist doesn't care as it creates the source folder with the name $(TF_A_DIR), > and extracts the tarball inside it by skipping the first folder part (tar's > --strip-components parameter, which is set to $(TF_A_STRIP_LEVEL), which > defaults to 1). Tarballs from git are actually the reason for that: The directory in the tarball is often derived from the tag name and in many cases, that does not include the project name. Having a directory named v2.12 in build-target/ is not a good idea, so I implemented to current logic. Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |