From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 08 Nov 2024 15:18:19 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1t9PoX-006Lv4-2k for lore@lore.pengutronix.de; Fri, 08 Nov 2024 15:18:19 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1t9PoY-0004RM-BK; Fri, 08 Nov 2024 15:18:18 +0100 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[IPV6:::1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1t9PoW-0004RA-3e; Fri, 08 Nov 2024 15:18:16 +0100 Message-ID: <738b1630-08d0-40d4-ba0d-bb663c2dec09@pengutronix.de> Date: Fri, 8 Nov 2024 15:18:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Bastian Krause , distrokit@pengutronix.de References: <20241108135752.1341526-1-bst@pengutronix.de> Content-Language: en-US From: Ahmad Fatoum In-Reply-To: <20241108135752.1341526-1-bst@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [DistroKit] [PATCH] v7a_noneon: barebox-at91: use ARM-optimized SHA1 implementation X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hello Bastian, On 08.11.24 14:57, Bastian Krause wrote: > Enable the SHA1 acceleration for barebox-at91, which so far had only the > generic SHA1 implementation enabled. This is ok, but keep in mind that the platform is called v7a_noneon for a reason. CONFIG_SHA256_ARM=y in barebox uses NEON instructions, which are not supported on the SAMA5D3. Cheers, Ahmad > > Signed-off-by: Bastian Krause > --- > configs/platform-v7a_noneon/barebox-at91.config | 2 +- > configs/platform-v7a_noneon/barebox-at91.config.diff | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/configs/platform-v7a_noneon/barebox-at91.config b/configs/platform-v7a_noneon/barebox-at91.config > index 53d40be12..cdf0b1af6 100644 > --- a/configs/platform-v7a_noneon/barebox-at91.config > +++ b/configs/platform-v7a_noneon/barebox-at91.config > @@ -1055,7 +1055,7 @@ CONFIG_DIGEST_SHA1_GENERIC=y > # CONFIG_DIGEST_SHA384_GENERIC is not set > # CONFIG_DIGEST_SHA512_GENERIC is not set > # CONFIG_DIGEST_HMAC_GENERIC is not set > -# CONFIG_DIGEST_SHA1_ARM is not set > +CONFIG_DIGEST_SHA1_ARM=y > # CONFIG_DIGEST_SHA256_ARM is not set > # CONFIG_CRYPTO_KEYSTORE is not set > # end of Crypto support > diff --git a/configs/platform-v7a_noneon/barebox-at91.config.diff b/configs/platform-v7a_noneon/barebox-at91.config.diff > index 378ae1ba6..872555226 100644 > --- a/configs/platform-v7a_noneon/barebox-at91.config.diff > +++ b/configs/platform-v7a_noneon/barebox-at91.config.diff > @@ -55,6 +55,7 @@ CONFIG_CONSOLE_ACTIVATE_NONE=y > CONFIG_DEBUG_AT91_UART_BASE=0xffffee00 > # CONFIG_DEBUG_PBL is not set > # CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW_MENU is undefined > +CONFIG_DIGEST_SHA1_ARM=y > # CONFIG_DRIVER_NET_DSA_REALTEK is not set > # CONFIG_DRIVER_NET_KSZ8873 is not set > CONFIG_DRIVER_NET_KSZ9477=y -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |