From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 18 Mar 2024 15:17:51 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rmDoF-00COeo-2h for lore@lore.pengutronix.de; Mon, 18 Mar 2024 15:17:51 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rmDoE-00045b-TC; Mon, 18 Mar 2024 15:17:50 +0100 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rmDoC-00045F-0S; Mon, 18 Mar 2024 15:17:48 +0100 Message-ID: <632f4139-1c83-4073-b43f-159dc3b7739b@pengutronix.de> Date: Mon, 18 Mar 2024 15:17:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Marco Felsch References: <20240318140633.1997386-1-a.fatoum@pengutronix.de> <20240318141041.ztq5yj262s4cpgpj@pengutronix.de> From: Ahmad Fatoum In-Reply-To: <20240318141041.ztq5yj262s4cpgpj@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [DistroKit] [PATCH] v8a: barebox: compress with XZ X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Olbrich , distrokit@pengutronix.de Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On 18.03.24 15:10, Marco Felsch wrote: > On 24-03-18, Ahmad Fatoum wrote: >> This saves us 124K, which we dearly need, because otherwise barebox >> would overlap the environment partition. The environment partition >> is reserved in the genimage config, but it's used due to the description >> in the barebox device tree. We may want to change both, but for now, buy >> us some time by switching from LZO to XZ. > > Why not making use of ZSTD instead? There's no ZSTD option for barebox proper compression. I had evaluated it a while ago, but found the ZSTD decompressor to be too big to make it worthwhile. See https://lore.barebox.org/barebox/20220713100922.1880282-1-a.fatoum@pengutronix.de/ Cheers, Ahmad > > Regards, > Marco > >> Reported-by: Michael Olbrich >> Signed-off-by: Ahmad Fatoum >> --- >> configs/platform-v8a/barebox.config | 13 ++++++++++--- >> 1 file changed, 10 insertions(+), 3 deletions(-) >> >> diff --git a/configs/platform-v8a/barebox.config b/configs/platform-v8a/barebox.config >> index 26be35533173..699b4f324afa 100644 >> --- a/configs/platform-v8a/barebox.config >> +++ b/configs/platform-v8a/barebox.config >> @@ -163,9 +163,9 @@ CONFIG_USE_COMPRESSED_DTB=y >> CONFIG_PBL_RELOCATABLE=y >> CONFIG_IMAGE_COMPRESSION=y >> # CONFIG_IMAGE_COMPRESSION_LZ4 is not set >> -CONFIG_IMAGE_COMPRESSION_LZO=y >> +# CONFIG_IMAGE_COMPRESSION_LZO is not set >> # CONFIG_IMAGE_COMPRESSION_GZIP is not set >> -# CONFIG_IMAGE_COMPRESSION_XZKERN is not set >> +CONFIG_IMAGE_COMPRESSION_XZKERN=y >> # CONFIG_IMAGE_COMPRESSION_NONE is not set >> CONFIG_MMU=y >> CONFIG_BAREBOX_MAX_IMAGE_SIZE=0xffffffff >> @@ -1063,7 +1063,14 @@ CONFIG_ZLIB=y >> # CONFIG_BZLIB is not set >> # CONFIG_LZ4_DECOMPRESS is not set >> # CONFIG_ZSTD_DECOMPRESS is not set >> -# CONFIG_XZ_DECOMPRESS is not set >> +CONFIG_XZ_DECOMPRESS=y >> +CONFIG_XZ_DEC_X86=y >> +CONFIG_XZ_DEC_POWERPC=y >> +CONFIG_XZ_DEC_IA64=y >> +CONFIG_XZ_DEC_ARM=y >> +CONFIG_XZ_DEC_ARMTHUMB=y >> +CONFIG_XZ_DEC_SPARC=y >> +CONFIG_XZ_DEC_ARM64=y >> # CONFIG_BASE64 is not set >> CONFIG_GENERIC_FIND_NEXT_BIT=y >> CONFIG_PROCESS_ESCAPE_SEQUENCE=y >> -- >> 2.39.2 >> >> >> > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |