From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: From: Ahmad Fatoum References: <20210312135530.32474-1-o.rempel@pengutronix.de> <20210312213006.lrk37yp7xrkatfyf@pengutronix.de> <20210315093312.setyxtiy4u3m6klk@pengutronix.de> Message-ID: <4deae1d9-d38d-74ea-89f1-0b8b647971df@pengutronix.de> Date: Mon, 29 Mar 2021 11:52:35 +0200 MIME-Version: 1.0 In-Reply-To: <20210315093312.setyxtiy4u3m6klk@pengutronix.de> Content-Language: en-US Subject: Re: [DistroKit] [PATCH v1] platform-v7a_sisd: sama5: platform w/out NEON extension List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Errors-To: distrokit-bounces@pengutronix.de Sender: "DistroKit" To: Robert Schwebel , Oleksij Rempel Cc: Holger Assmann , distrokit@pengutronix.de, =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= On 15.03.21 10:33, Robert Schwebel wrote: > On Fri, Mar 12, 2021 at 10:30:06PM +0100, Uwe Kleine-K=F6nig wrote: >> On Fri, Mar 12, 2021 at 02:55:30PM +0100, Oleksij Rempel wrote: >>> create mode 100644 configs/platform-v7a_sisd/patches/barebox-at91-stag= e1-2020.08.1/0001-HACK-ARM-at91-microchip-ksz9477-provide-first-stage-.patch >>> create mode 100644 configs/platform-v7a_sisd/patches/barebox-at91-stag= e1-2020.08.1/0002-ARM-at91-microchip-ksz9477-evb-implement-first-stage.patch >>> create mode 100644 configs/platform-v7a_sisd/patches/barebox-at91-stag= e1-2020.08.1/0003-fixup-HACK-ARM-at91-microchip-ksz9477-provide-first-.patch >> >> What is the good reason to have a fixup patch in a patch stack? Why not >> squash it? > = > The patches look a bit questionable for DistroKit. Please rework. Yes, Oleksij, please do :-) FTR: barebox has a multi-image at91_multi_defconfig, which builds multiple = boards in one go. For the two sama5d27 boards, this includes both first stage and = second stage bootloaders. The patches included here, require two barebox images to be built with diff= erent configs. One minimal image (BOOT.BIN) to fit into 64k SRAM, which in turn l= oads the bigger barebox image (barebox.bin) from FAT into DRAM. What's basically missing is a PBL driver to chainload barebox.bin from the = BOOT.BIN prebootloader. This is already possible with the sama5d27, so that can be u= sed as reference point. SAMA5D2 and D3 have different SD host controllers, howe= ver. Good luck! Ahmad > = > rsc > = > = > _______________________________________________ > DistroKit mailing list > DistroKit@pengutronix.de > = -- = Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ DistroKit mailing list DistroKit@pengutronix.de