From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 06 Jun 2023 17:03:00 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q6YD7-00DB2d-QF for lore@lore.pengutronix.de; Tue, 06 Jun 2023 17:03:00 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1q6YD4-000172-Ti; Tue, 06 Jun 2023 17:02:58 +0200 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1q6YD3-00016d-9y; Tue, 06 Jun 2023 17:02:57 +0200 Message-ID: <28d04b2f-a550-65a2-92f5-0b8280af46db@pengutronix.de> Date: Tue, 6 Jun 2023 17:02:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US, de-DE To: =?UTF-8?Q?Jan_L=c3=bcbbe?= , Ahmad Fatoum , distrokit@pengutronix.de References: <20230606-default_enable_fastboot_rock3a-v1-0-42195d538df2@pengutronix.de> <20230606-default_enable_fastboot_rock3a-v1-1-42195d538df2@pengutronix.de> <8a2453a6-e72f-7a0f-fae3-9f15037927c4@pengutronix.de> <2ce49103c03130f46193c2f235ccbb17da2a8533.camel@pengutronix.de> From: Johannes Zink In-Reply-To: <2ce49103c03130f46193c2f235ccbb17da2a8533.camel@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [DistroKit] [PATCH 1/5] v8a: enable initrd generation X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: patchwork-jzi@pengutronix.de Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Hi Jan, On 6/6/23 16:59, Jan Lübbe wrote: > On Tue, 2023-06-06 at 16:44 +0200, Johannes Zink wrote: >> Hi Ahmad, >> >> On 6/6/23 16:37, Ahmad Fatoum wrote: >>> On 06.06.23 16:31, Johannes Zink wrote: >>>> also generate rootfs as cpio.gz, as this allows loading it as initramfs. >>> >>> You enable both CONFIG_RD_GZIP and CONFIG_RD_ZSTD (which I am fine with), >>> but you decide here for cpio.gz. Any particular reason? >> >> afaik ZSTD support is rather new and I wanted to have maximum flexibility when >> reusing the initramfs, even with older kernels - i.e. being able to mix a >> ptxdist-built initramfs with older kernels. I opted to also support zstd, to >> allow booting future initramfs' on current kernels, should gzip support ever be >> dropped in the future. >> >> However, I think we could probably drop the zstd support, if you are concerned >> about image size. > > CONFIG_KERNEL_ZSTD is supported since 5.9: > https://cateee.net/lkddb/web-lkddb/KERNEL_ZSTD.html > > In cases where an old kernel should be booted with this new initramfs, you can > just recompress it with gz on the host (which is trivial compared to building it > in the first place). > > I'd suggest just going with zstd only. > > Jan ack, gonna change support to zstd and drop gz in v2 of this series. Johannes -- Pengutronix e.K. | Johannes Zink | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 |