From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 09 Jun 2023 11:53:55 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q7Yoe-00H0Ot-EY for lore@lore.pengutronix.de; Fri, 09 Jun 2023 11:53:55 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1q7Yob-0005DJ-O3; Fri, 09 Jun 2023 11:53:53 +0200 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1q7YoU-0005Cv-4F; Fri, 09 Jun 2023 11:53:46 +0200 Message-ID: <23f6a23c-0145-b5b6-ede8-9d265a668c42@pengutronix.de> Date: Fri, 9 Jun 2023 11:53:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US, de-DE To: =?UTF-8?Q?Jan_L=c3=bcbbe?= , Ahmad Fatoum , distrokit@pengutronix.de References: <20230606-default_enable_fastboot_rock3a-v1-0-42195d538df2@pengutronix.de> <20230606-default_enable_fastboot_rock3a-v1-5-42195d538df2@pengutronix.de> <9a5a0fff-266f-4e76-e95b-b1759e88c1a0@pengutronix.de> From: Johannes Zink In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [DistroKit] [PATCH 5/5] v8a: barebox: add a boot target for fastboot loaded image files X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: patchwork-jzi@pengutronix.de Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Hi Jan, On 6/6/23 17:07, Jan Lübbe wrote: > On Tue, 2023-06-06 at 16:47 +0200, Ahmad Fatoum wrote: >> On 06.06.23 16:31, Johannes Zink wrote: >>> This allows to boot a kernel with dtb and initrd entirely from RAM after >>> loading it via Android Fastboot by simply calling 'boot fastboot'. >>> >>> Signed-off-by: Johannes Zink >>> --- >>> configs/platform-v8a/barebox-common-defaultenv/boot/fastboot | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/configs/platform-v8a/barebox-common-defaultenv/boot/fastboot b/configs/platform-v8a/barebox-common-defaultenv/boot/fastboot >>> new file mode 100755 >>> index 000000000000..a06414d582bf >>> --- /dev/null >>> +++ b/configs/platform-v8a/barebox-common-defaultenv/boot/fastboot >>> @@ -0,0 +1,7 @@ >>> +#!/bin/sh >>> + >>> +global.bootm.image=/tmp/kernel >>> +global.bootm.initrd=/tmp/initramfs >>> +global.bootm.oftree=/tmp/oftree >>> + >>> +global.linux.bootargs.dyn.root="rdinit=/sbin/init root=/dev/ram" >> >> Isn't rdinit=/sbin/init the default? > > rd=/init is the defaut. root=/dev/ram is not needed, AFAIR, it's for initrd, not > initramfs. > > Also, we could add a symlink /init -> /sbin/init, which would simplify using > this initramfs with a bootloaders not passing the correct cmdline. > > Jan I have tested the different permutations: +-------------------+---------------+-----------+ | rdinit=/sbin/init | root=/dev/ram | result | +===================+===============+===========+ | set | set | boots | +-------------------+---------------+-----------+ | set | not set | boots | +-------------------+---------------+-----------+ | not set | set | fails [1] | +-------------------+---------------+-----------+ | not set | not set | fails [1] | +-------------------+---------------+-----------+ [1] kernel panic after [ 2.545914] /dev/root: Can't open blockdev [ 2.546279] VFS: Cannot open root device "ram" or unknown-block(1,0): error -6 Thus, we can drop the root=/dev/ram, as you suggested. Gonna change it in v2. Johannes -- Pengutronix e.K. | Johannes Zink | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 |