From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 17 Jun 2024 11:24:08 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sJ8au-007VYg-1i for lore@lore.pengutronix.de; Mon, 17 Jun 2024 11:24:08 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sJ8at-0003W0-Ry; Mon, 17 Jun 2024 11:24:07 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sJ8aq-0003Vs-8E for distrokit@pengutronix.de; Mon, 17 Jun 2024 11:24:04 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sJ8ap-002wRL-Rs for distrokit@pengutronix.de; Mon, 17 Jun 2024 11:24:03 +0200 Received: from rhi by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1sJ8ap-00G5vq-2V for distrokit@pengutronix.de; Mon, 17 Jun 2024 11:24:03 +0200 Date: Mon, 17 Jun 2024 11:24:03 +0200 From: Roland Hieber To: distrokit@pengutronix.de Message-ID: <20240617092403.sky4qlang6atjbgt@pengutronix.de> References: <20240611102756.3709016-1-rhi@pengutronix.de> <20240613-whenever-enduring-698a9b93370b@thorsis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240613-whenever-enduring-698a9b93370b@thorsis.com> Subject: Re: [DistroKit] [PATCH] datapartition: make it selectable X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Thu, Jun 13, 2024 at 09:31:27AM +0200, Alexander Dahl wrote: > Hello Roland, > > Am Tue, Jun 11, 2024 at 12:27:56PM +0200 schrieb Roland Hieber: > > The data partition is not needed for all aspects of the system, and > > running systemd-repart to recreate it after writing a new image slows > > the debugging cycle considerably. Make it de-selectable to speed up the > > debugging process. > > +1 for the general idea. > > However I noticed two things when testing this: > > First: The datapartition package also targetinstalls the conf files > for creating the root-B partition to /etc/repart.rc-once.d/ which is > not created now anymore. I guess the idea of the patch was to avoid > systemd-repart, but at least the commit message claims only the data > partition create is skipped. Maybe installing those conf files in the > datapartition package was an unfortunate mixup to begin with. Good point. But no, the datapartition contained a similar setup before, using sfdisk to create the partition, which somehow broke at some time in the past. So I took that as an opportunity to create the other partition in the same setup while porting it to systemd-repart. But I think it would make sense now to rename the recipe in the next patch iteration. > Second: this is the second package now with category > 'project_specific' which shows up directly at the top level in the > menu (ptxdist menuconfig, the other one is rauc-udev). I would > propose to use a submenu instead and move these DistroKit specific > packages over there. Good idea. - Roland > Greets > Alex > > > > > Signed-off-by: Roland Hieber > > --- > > rules/datapartition.in | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/rules/datapartition.in b/rules/datapartition.in > > index 5b8c737fb8ad..152a60633658 100644 > > --- a/rules/datapartition.in > > +++ b/rules/datapartition.in > > @@ -1,7 +1,7 @@ > > ## SECTION=project_specific > > > > config DATAPARTITION > > - tristate > > + tristate "datapartition" > > select RC_ONCE > > select SYSTEMD > > select SYSTEMD_REPART > > -- > > 2.39.2 > > > > > -- Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |