From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 13 Jun 2024 09:31:43 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sHevv-005FWH-03 for lore@lore.pengutronix.de; Thu, 13 Jun 2024 09:31:43 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sHevu-0006fn-Dc; Thu, 13 Jun 2024 09:31:42 +0200 Received: from mail.thorsis.com ([217.92.40.78]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sHevo-0006fU-7U; Thu, 13 Jun 2024 09:31:38 +0200 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 5F2301486704; Thu, 13 Jun 2024 09:31:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thorsis.com; s=dkim; t=1718263895; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=tAcUdGCPiSXIYYASRP4phYlCv/nAIYooVNKd6Gw0xdg=; b=PVecgcEn4DVBAME4g4tO63/qp7+C52i6wgxP5euYQ4PbVmjGQtbK8CI0tj86nLYtESndsK bJoYd/saEw/84tiWbMyxN0c6r3p+8aMb1bRAFJakqUF29Jz9StwYv4sLtOdFYcdUkyBFPN ktEj4EMGblc1xoI877YqWNfea5nC2D4ixjFGQRrJ+xm6RlyxCjMPgitqfjJsA+R+JUZUmy NgOXTRFB2ThPiDj1EjDdZVlNAfWpb4OTD1Km8zaEz64si+0NjtDEqwnJe2sYV3zLjTgrLy Xs6VSIR9FwDOGbZAhc8puvk5LNU1BDJNcfRhdWBgjvK16Ku0MP8RfZIlnhCiNQ== Date: Thu, 13 Jun 2024 09:31:27 +0200 From: Alexander Dahl To: Roland Hieber Message-ID: <20240613-whenever-enduring-698a9b93370b@thorsis.com> Mail-Followup-To: Roland Hieber , distrokit@pengutronix.de References: <20240611102756.3709016-1-rhi@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240611102756.3709016-1-rhi@pengutronix.de> User-Agent: Mutt/2.2.12 (2023-09-09) X-Last-TLS-Session-Version: TLSv1.3 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.8 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [DistroKit] [PATCH] datapartition: make it selectable X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: distrokit@pengutronix.de Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hello Roland, Am Tue, Jun 11, 2024 at 12:27:56PM +0200 schrieb Roland Hieber: > The data partition is not needed for all aspects of the system, and > running systemd-repart to recreate it after writing a new image slows > the debugging cycle considerably. Make it de-selectable to speed up the > debugging process. +1 for the general idea. However I noticed two things when testing this: First: The datapartition package also targetinstalls the conf files for creating the root-B partition to /etc/repart.rc-once.d/ which is not created now anymore. I guess the idea of the patch was to avoid systemd-repart, but at least the commit message claims only the data partition create is skipped. Maybe installing those conf files in the datapartition package was an unfortunate mixup to begin with. Second: this is the second package now with category 'project_specific' which shows up directly at the top level in the menu (ptxdist menuconfig, the other one is rauc-udev). I would propose to use a submenu instead and move these DistroKit specific packages over there. Greets Alex > > Signed-off-by: Roland Hieber > --- > rules/datapartition.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/rules/datapartition.in b/rules/datapartition.in > index 5b8c737fb8ad..152a60633658 100644 > --- a/rules/datapartition.in > +++ b/rules/datapartition.in > @@ -1,7 +1,7 @@ > ## SECTION=project_specific > > config DATAPARTITION > - tristate > + tristate "datapartition" > select RC_ONCE > select SYSTEMD > select SYSTEMD_REPART > -- > 2.39.2 > >