From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 13 Dec 2023 17:49:58 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rDSQn-002Js7-2L for lore@lore.pengutronix.de; Wed, 13 Dec 2023 17:49:58 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rDSQo-0005bC-3Z; Wed, 13 Dec 2023 17:49:58 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rDSQl-0005b4-AX for distrokit@pengutronix.de; Wed, 13 Dec 2023 17:49:55 +0100 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rDSQk-00Fc5o-UT for distrokit@pengutronix.de; Wed, 13 Dec 2023 17:49:54 +0100 Received: from rhi by pty.whiteo.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rDSQk-00DXIN-LR for distrokit@pengutronix.de; Wed, 13 Dec 2023 17:49:54 +0100 Date: Wed, 13 Dec 2023 17:49:54 +0100 From: Roland Hieber To: distrokit@pengutronix.de Message-ID: <20231213164954.dqqrull43flrvhuh@pengutronix.de> References: <20230926083205.1648523-1-rhi@pengutronix.de> <20230926-harmony-thursday-44ea6336278d@ifak-system.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230926-harmony-thursday-44ea6336278d@ifak-system.com> Subject: Re: [DistroKit] [ptxdist] [PATCH] ptxd_make_vcs_version: always use all Git tags X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Just FYI; I initially sent the PTXdist patch because my DistroKit version in /etc/issue still showed something very old with a big number behind it, like "2019.12.0-00529-g1938a270ab52", because the recent tags in the Git repo were non-signed tags. - Roland On Tue, Sep 26, 2023 at 12:13:58PM +0200, Alexander Dahl wrote: > Hello Roland, > > Am Tue, Sep 26, 2023 at 10:32:05AM +0200 schrieb Roland Hieber: > > The short-circuit results in a preference of signed tags over non-signed > > tags. In BSPs where non-signed tags exist (e.g. DistroKit-2023.09.0) > > that are newer than the latest signed tag (e.g. DistroKit-2019.12.0), > > this will always lead to an unnecessarily old tag being used. > > Maybe this thread from 2018 can help (been there, tried that): > > https://lore.ptxdist.org/ptxdist/20180907100105.nleg2qmttyahcmzm@pengutronix.de/ > > Greets > Alex > > > > > Cc: Steffen Trumtrar > > Signed-off-by: Roland Hieber > > --- > > Steffen, do you still know why you chose a plain "git describe" first? > > > > > > scripts/lib/ptxd_make_vcs_version.sh | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/scripts/lib/ptxd_make_vcs_version.sh b/scripts/lib/ptxd_make_vcs_version.sh > > index 69e486ab31a5..d59e1eba9872 100644 > > --- a/scripts/lib/ptxd_make_vcs_version.sh > > +++ b/scripts/lib/ptxd_make_vcs_version.sh > > @@ -7,8 +7,7 @@ > > # > > > > ptxd_make_vcs_version() { > > - PTXDIST_VCS_VERSION="$(git describe 2>/dev/null || \ > > - git describe --always --tags 2>/dev/null)" > > + PTXDIST_VCS_VERSION="$(git describe --always --tags 2>/dev/null)" > > > > if [ -z "${PTXDIST_VCS_VERSION}" ]; then > > PTXDIST_VCS_VERSION="unknown" > > -- > > 2.39.2 > > > > > > -- Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |