From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 13 Dec 2023 15:48:16 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rDQX1-002G7G-0z for lore@lore.pengutronix.de; Wed, 13 Dec 2023 15:48:16 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rDQX1-0007fA-Jv; Wed, 13 Dec 2023 15:48:15 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rDQWt-0007TL-Rl; Wed, 13 Dec 2023 15:48:07 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rDQWt-00FapP-E5; Wed, 13 Dec 2023 15:48:07 +0100 Received: from rhi by dude04.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rDQWt-0081CT-1B; Wed, 13 Dec 2023 15:48:07 +0100 From: Roland Hieber To: distrokit@pengutronix.de Date: Wed, 13 Dec 2023 15:47:50 +0100 Message-Id: <20231213144750.1899431-5-rhi@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231213144750.1899431-1-rhi@pengutronix.de> References: <20231213144750.1899431-1-rhi@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [DistroKit] [PATCH next v3 4/4] fixup! rauc-udev: generate symlinks based on GPT partition labels X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Roland Hieber Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Signed-off-by: Roland Hieber --- The assumption made in the comment does not hold true, as the fallback match for mmcblk0p3 conflicts with any possible match made later with the 'boot_disk' tag a few lines below, so the probe order will influence the actual target of the symlink and lead to unwanted consequences. Since we removed the data partition from all genimage configs in a previous commit ("treewide: images: remove root-B and data partitions"), the fallback does not match anyway. --- projectroot/usr/lib/udev/rules.d/90-rauc-partitions.rules | 4 ---- 1 file changed, 4 deletions(-) diff --git a/projectroot/usr/lib/udev/rules.d/90-rauc-partitions.rules b/projectroot/usr/lib/udev/rules.d/90-rauc-partitions.rules index 2da28ae5df16..e2893fa051f9 100644 --- a/projectroot/usr/lib/udev/rules.d/90-rauc-partitions.rules +++ b/projectroot/usr/lib/udev/rules.d/90-rauc-partitions.rules @@ -20,10 +20,6 @@ ENV{OF_BASE_COMPATIBLE}=="*radxa,rock3a*", ENV{ID_PATH}=="platform-fe2b0000.mmc" # second part: create /dev/disk/by-usage/ symlinks ENV{DEVTYPE}!="partition", GOTO="rauc_partitions_end" -# fallback for boards not yet supported by RAUC; -# this will get overwritten below if we detected the boot disk -KERNEL=="mmcblk0p3", SYMLINK+="disk/by-usage/data" - # symlinks based on GPT partition labels TAGS=="boot_disk", ENV{ID_PART_ENTRY_NAME}=="root-A", SYMLINK+="disk/by-usage/rootfs0" TAGS=="boot_disk", ENV{ID_PART_ENTRY_NAME}=="root-B", SYMLINK+="disk/by-usage/rootfs1" -- 2.39.2