From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 11 Dec 2023 11:32:35 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rCdaU-000Kky-1N for lore@lore.pengutronix.de; Mon, 11 Dec 2023 11:32:35 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rCdaU-00064l-Qa; Mon, 11 Dec 2023 11:32:34 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rCdaR-00064W-14; Mon, 11 Dec 2023 11:32:31 +0100 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rCdaQ-00F4kn-L4; Mon, 11 Dec 2023 11:32:30 +0100 Received: from rhi by pty.whiteo.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rCdaQ-00ASGa-CA; Mon, 11 Dec 2023 11:32:30 +0100 Date: Mon, 11 Dec 2023 11:32:30 +0100 From: Roland Hieber To: Ahmad Fatoum Message-ID: <20231211103230.uqym3vvnkq6zpb7l@pengutronix.de> References: <20231122185535.2051569-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231122185535.2051569-1-a.fatoum@pengutronix.de> Subject: Re: [DistroKit] [PATCH] v7a: barebox: define state for all supported board variants X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: distrokit@pengutronix.de Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Wed, Nov 22, 2023 at 07:55:35PM +0100, Ahmad Fatoum wrote: > Boot up is broken on some of the Raspberry Pi and STM32MP1 board we > support, because boot method is changed to bootchooser, but state isn't > defined. Fix this by extending state definition to the missed boards. > > Signed-off-by: Ahmad Fatoum > --- > configs/platform-v7a/dts/bootstate.dtsi | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/configs/platform-v7a/dts/bootstate.dtsi b/configs/platform-v7a/dts/bootstate.dtsi > index c77df2e19d65..cd24d74d4aea 100644 > --- a/configs/platform-v7a/dts/bootstate.dtsi > +++ b/configs/platform-v7a/dts/bootstate.dtsi > @@ -39,8 +39,11 @@ > }; > #endif > > -/** Raspberry Pi 3 Model B ****************************************************/ > -#ifdef bcm2837_rpi_3_dts > +/** Raspberry Pi **************************************************************/ > +#if defined(bcm2836_rpi_2_dts) || \ Interesting, the kernel DT file names are apparently named "rpi-3-b" and "rpi-2-b" now, but the "-b" is not part of the barebox device trees. Anyway, that's a different issue, the patch looks fine to me. Reviewed-by: Roland Hieber > + defined(bcm2837_rpi_3_dts) || \ > + defined(bcm2837_rpi_cm3_dts) || \ > + defined(bcm2711_rpi_4_dts) > / { > aliases { > state = &state; > @@ -101,8 +104,10 @@ > }; > #endif > > -/** LXA MC1 *******************************************************************/ > -#ifdef stm32mp157c_lxa_mc1_dts > +/** STM32MP1 ******************************************************************/ > +#if defined(stm32mp157c_lxa_mc1_dts) || \ > + defined(stm32mp157c_dk2_dts) || \ > + defined(stm32mp157c_ev1_dts) > / { > aliases { > state = &state_mmc0; > -- > 2.39.2 > > > -- Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |