DistroKit Mailinglist
 help / color / mirror / Atom feed
From: Michael Grzeschik <mgr@pengutronix.de>
To: Robert Schwebel <r.schwebel@pengutronix.de>
Cc: distrokit@pengutronix.de, "Jan Lübbe" <jlu@pengutronix.de>
Subject: Re: [DistroKit] [PATCH] x86_64: run: add 9p support
Date: Wed, 1 Mar 2023 20:24:42 +0100	[thread overview]
Message-ID: <20230301192442.GH6678@pengutronix.de> (raw)
In-Reply-To: <20230301155534.GH17576@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 3347 bytes --]

On Wed, Mar 01, 2023 at 04:55:34PM +0100, Robert Schwebel wrote:
>On Tue, Jan 31, 2023 at 07:50:40AM +0100, Jan Lübbe wrote:
>> On Mon, 2023-01-30 at 23:03 +0100, Michael Grzeschik wrote:
>> > copy the qemu 9p rule from platform v7a and make 9p the default
>> >
>> > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
>> > ---
>> >  configs/platform-x86_64/run | 23 ++++++++++++++++++++++-
>> >  1 file changed, 22 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/configs/platform-x86_64/run b/configs/platform-x86_64/run
>> > index c39d5a7b..96322292 100755
>> > --- a/configs/platform-x86_64/run
>> > +++ b/configs/platform-x86_64/run
>> > @@ -67,6 +67,12 @@ fi
>> >
>> >  BASE_CMDLINE="console=ttyS0,115200 loglevel=5 systemd.log_level=warning systemd.show_status=auto"
>> >
>> > +if [ -d "${PTXDIST_PLATFORMDIR}/root/.virtfs_metadata" ]; then
>> > +	security_model="mapped-file"
>> > +else
>> > +	security_model="none"
>> > +fi
>> > +
>> >  # Machine to emulate
>> >  QEMU_ARGS=( -L ${PTXDIST_PLATFORMDIR}/sysroot-host/share/qemu/ -machine pc-q35-2.12 -smp 2 -cpu host -accel kvm -m 1G -s )
>> >  # disable graphics output
>> > @@ -97,7 +103,22 @@ run_qemu_hda() {
>> >  		-append "root=/dev/vda console=ttyS0,115200 rw ${BASE_CMDLINE}"
>> >  }
>> >
>> > -target="${1:-hda}"
>> > +#
>> > +# This needs:
>> > +# CONFIG_NET_9P_VIRTIO=y
>> > +# CONFIG_9P_FS=y
>> > +#
>> > +run_qemu_9p() {
>> > +	exec ${QEMU_EXEC} \
>> > +		"${QEMU_ARGS[@]}" \
>> > +		-fsdev local,id=rootfs,path=${PTXDIST_PLATFORMDIR}/root,security_model="${security_model}" \
>> > +		-device virtio-9p-pci,fsdev=rootfs,mount_tag=/dev/root \
>> > +		"${QEMU_EXTRA_ARGS[@]}" \
>> > +		"${QEMU_LINUX_ARGS[@]}" \
>> > +		-append "root=/dev/root rw rootfstype=9p rootflags=trans=virtio ${BASE_CMDLINE}"
>>
>> You should set msize explicitly do make it less likely that some userspace tools
>> are confused by short reads from 9pfs (nginx for example).
>
>Care to re-send?

Sure! But:

@jluebbe: I found your discussion about setting explicit msize in the
qemu virtio parameters.

https://gitlab.com/qemu-project/qemu/-/issues/409

However I did not find out which reasonable value to set from the
thread, since the discussion is talking about different causes to
trigger the issues. e.g. tar without O_PARTIAL in the kernel headers.

Would msize=104857600 be something to work with?

I also found some patches that are there to solve the issue probably,
but they got not mainlined yet.

https://lore.kernel.org/netdev/cover.1640870037.git.linux_oss@crudebyte.com/

mgr

>> > +}
>> > +
>> > +target="${1:-9p}"
>> >
>> >  #set -x
>> >  run_qemu_${target}
>
>rsc
>-- 
>Pengutronix e.K.                           | Dipl.-Ing. Robert Schwebel  |
>Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
>31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
>Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |
>

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2023-03-01 19:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-30 22:03 Michael Grzeschik
2023-01-31  6:50 ` Jan Lübbe
2023-03-01 15:55   ` Robert Schwebel
2023-03-01 19:24     ` Michael Grzeschik [this message]
2023-03-02  7:48       ` Jan Lübbe
2023-03-02  8:06         ` [DistroKit] [PATCH v2] " Michael Grzeschik
2023-03-24 23:39           ` Michael Grzeschik
2023-03-25  6:24             ` Robert Schwebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230301192442.GH6678@pengutronix.de \
    --to=mgr@pengutronix.de \
    --cc=distrokit@pengutronix.de \
    --cc=jlu@pengutronix.de \
    --cc=r.schwebel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox