DistroKit Mailinglist
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: distrokit@pengutronix.de
Subject: Re: [DistroKit] [PATCH 10/14] blspec-entry: add linux-appendroot support
Date: Mon, 13 Feb 2023 10:00:46 +0100	[thread overview]
Message-ID: <20230213090046.GF30852@pengutronix.de> (raw)
In-Reply-To: <20230210193612.2143905-11-m.felsch@pengutronix.de>

On Fri, Feb 10, 2023 at 08:36:08PM +0100, Marco Felsch wrote:
> Add the option to add the 'linux-appendroot true' to blspec config file
> which is very useful in case of using barebox as bootlaoder.

You wanted to send a v2 to get this upstream...

Michael

> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  platforms/blspec-entry.in               |  8 ++++++++
>  projectroot/loader/entries/default.conf |  1 +
>  rules/blspec-entry.make                 | 10 +++++++++-
>  3 files changed, 18 insertions(+), 1 deletion(-)
> 
> diff --git a/platforms/blspec-entry.in b/platforms/blspec-entry.in
> index aed65d4..c2aea36 100644
> --- a/platforms/blspec-entry.in
> +++ b/platforms/blspec-entry.in
> @@ -16,4 +16,12 @@ config BLSPEC_ENTRY_CMDLINE
>  	string
>  	prompt "kernel command-line"
>  
> +config BLSPEC_ENTRY_APPENDROOT
> +	bool
> +	prompt "Add 'linux-appendroot true'"
> +	help
> +	  If enabled this options adds 'linux-appendroot true' to the blspec
> +	  entry. This is a barebox specific blspec option which tells barebox
> +	  to add the 'root=' kernel command line automatically if set.
> +
>  endif
> diff --git a/projectroot/loader/entries/default.conf b/projectroot/loader/entries/default.conf
> index 5650907..d281569 100644
> --- a/projectroot/loader/entries/default.conf
> +++ b/projectroot/loader/entries/default.conf
> @@ -3,3 +3,4 @@ version		@VERSION@
>  options		@CMDLINE@
>  linux		@KERNEL@
>  @DEVICETREE@
> +@LINUXAPPENDROOT@
> diff --git a/rules/blspec-entry.make b/rules/blspec-entry.make
> index f393b1b..7523009 100644
> --- a/rules/blspec-entry.make
> +++ b/rules/blspec-entry.make
> @@ -35,6 +35,12 @@ else
>  BLSPEC_KERNEL_IMAGE	= $(KERNEL_IMAGE)
>  endif
>  
> +ifdef PTXCONF_BLSPEC_ENTRY_APPENDROOT
> +BLSPEC_APPENDROOT	= linux-appendroot\ttrue
> +else
> +BLSPEC_APPENDROOT	=
> +endif
> +
>  $(STATEDIR)/blspec-entry.targetinstall:
>  	@$(call targetinfo)
>  
> @@ -56,7 +62,9 @@ $(STATEDIR)/blspec-entry.targetinstall:
>  		$(call install_replace, blspec-entry, /loader/entries/$(name).conf, \
>  			@KERNEL@,'/boot/$(BLSPEC_KERNEL_IMAGE)')$(ptx/nl) \
>  		$(call install_replace, blspec-entry, /loader/entries/$(name).conf, \
> -			@DEVICETREE@,'$(call blspec/devicetree,$(name))')$(ptx/nl))
> +			@DEVICETREE@,'$(call blspec/devicetree,$(name))')$(ptx/nl) \
> +		$(call install_replace, blspec-entry, /loader/entries/$(name).conf, \
> +			@LINUXAPPENDROOT@,'$(BLSPEC_APPENDROOT)')$(ptx/nl))
>  
>  	@$(call install_finish,blspec-entry)
>  
> -- 
> 2.30.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



  reply	other threads:[~2023-02-13  9:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-10 19:35 [DistroKit] [PATCH 00/14] Mainline TF-A support and blspec-entry cleanups Marco Felsch
2023-02-10 19:35 ` [DistroKit] [PATCH 01/14] v7a: tf-a: version bump v2.7 -> 2.8/customers/pengutronix/distrokit/20230210-1 Marco Felsch
2023-02-10 19:36 ` [DistroKit] [PATCH 02/14] v8a: tf-a: enable package Marco Felsch
2023-02-10 19:36 ` [DistroKit] [PATCH 03/14] v8a: replace imx-atf with tf-a Marco Felsch
2023-02-10 19:36 ` [DistroKit] [PATCH 04/14] v8a: firmware-imx: fix dest path Marco Felsch
2023-02-10 19:36 ` [DistroKit] [PATCH 05/14] v8a: firmware-imx: fix destition path Marco Felsch
2023-02-10 19:36 ` [DistroKit] [PATCH 06/14] v8a: barebox-imx8m: fix firmware-imx dependencies Marco Felsch
2023-02-10 19:36 ` [DistroKit] [PATCH 07/14] v8a: barebox-imx8m: make use of the INJECT_FILES mechanism Marco Felsch
2023-02-10 19:36 ` [DistroKit] [PATCH 08/14] v8a: barebox: version sync to 2023.01.0 Marco Felsch
2023-02-10 19:36 ` [DistroKit] [PATCH 09/14] blspec-entry: import from upstream ptxdist-2022.12.0 Marco Felsch
2023-02-10 19:36 ` [DistroKit] [PATCH 10/14] blspec-entry: add linux-appendroot support Marco Felsch
2023-02-13  9:00   ` Michael Olbrich [this message]
2023-02-13 10:20     ` Marco Felsch
2023-02-10 19:36 ` [DistroKit] [PATCH 11/14] v8a: blspec: switch to default blspec entry Marco Felsch
2023-02-10 19:36 ` [DistroKit] [PATCH 12/14] v7a: blspec: drop incomplete Gute Fee support Marco Felsch
2023-02-10 19:36 ` [DistroKit] [PATCH 13/14] v7a: vexpress: remove console from blspec config Marco Felsch
2023-02-10 19:36 ` [DistroKit] [PATCH 14/14] v7a: blspec: convert to ptxdist default entries Marco Felsch
2023-02-11 20:59 ` [DistroKit] [PATCH 00/14] Mainline TF-A support and blspec-entry cleanups Robert Schwebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230213090046.GF30852@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=distrokit@pengutronix.de \
    --cc=m.felsch@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox