From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 25 Jun 2021 13:22:16 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1lwjua-0003el-K3 for lore@lore.pengutronix.de; Fri, 25 Jun 2021 13:22:16 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1lwjuZ-0003g2-VP; Fri, 25 Jun 2021 13:22:15 +0200 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwjuY-0003ft-Ky for distrokit@pengutronix.de; Fri, 25 Jun 2021 13:22:14 +0200 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lwjuY-0008OL-C2 for distrokit@pengutronix.de; Fri, 25 Jun 2021 13:22:14 +0200 Date: Fri, 25 Jun 2021 13:22:14 +0200 From: Michael Olbrich To: distrokit@pengutronix.de Message-ID: <20210625112214.GG25044@pengutronix.de> Mail-Followup-To: distrokit@pengutronix.de References: <20210625111546.18971-1-ada@thorsis.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210625111546.18971-1-ada@thorsis.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 13:20:03 up 127 days, 14:43, 124 users, load average: 0.43, 0.24, 0.20 User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [DistroKit] [PATCH] datapartition: Let systemd install custom udev rule X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Hi, On Fri, Jun 25, 2021 at 01:15:46PM +0200, Alexander Dahl wrote: > If DistroKit is used as a base layer and any upper layer enables > PTXCONF_SYSTEMD_UDEV_CUST_RULES, package installation might fail because > both packages, 'systemd' and 'datapartition' try to targetinstall > 'usr/lib/udev/rules.d/91-mkfs-ext4.rules', like this: > > Collected errors: > * check_data_file_clashes: Package datapartition wants to install file /home/adahl/Work/bsp/xxx/base/platform-v7a/build-target/image-root-tgz/usr/lib/udev/rules.d/91-mkfs-ext4.rules > But that file is already provided by package * systemd > * opkg_solver_install: Cannot install package datapartition. > make: *** [/usr/local/lib/ptxdist-2021.02.0/rules/image-root-tgz.make:30: /home/adahl/Work/bsp/xxx/base/platform-v7a/images/root.tgz] Error 255 NACK. An now 91-mkfs-ext4.rules won't be installed unless it is copied into each layer that provides udev rules. Don't use SYSTEMD_UDEV_CUST_RULES with layers. It doesn't work properly. Michael > Signed-off-by: Alexander Dahl > --- > configs/ptxconfig | 2 +- > rules/datapartition.make | 2 -- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/configs/ptxconfig b/configs/ptxconfig > index c97e321..a4fa7e9 100644 > --- a/configs/ptxconfig > +++ b/configs/ptxconfig > @@ -1437,7 +1437,7 @@ PTXCONF_SYSTEMD_ZSTD=y > # > PTXCONF_SYSTEMD_UDEV_DRIVERS_RULES=y > # PTXCONF_SYSTEMD_UDEV_HWDB is not set > -# PTXCONF_SYSTEMD_UDEV_CUST_RULES is not set > +PTXCONF_SYSTEMD_UDEV_CUST_RULES=y > # end of install options > > # > diff --git a/rules/datapartition.make b/rules/datapartition.make > index b79bcf0..7f3c992 100644 > --- a/rules/datapartition.make > +++ b/rules/datapartition.make > @@ -28,8 +28,6 @@ $(STATEDIR)/datapartition.targetinstall: > > @$(call install_alternative, datapartition, 0, 0, 0644, \ > /usr/lib/systemd/system/systemd-autoformat@.service) > - @$(call install_alternative, datapartition, 0, 0, 0644, \ > - /usr/lib/udev/rules.d/91-mkfs-ext4.rules) > > @$(call install_finish,datapartition) > > > base-commit: 085bb9b4273c8fd91105d9e149776f144f5fdd65 > -- > 2.30.2 > > > _______________________________________________ > DistroKit mailing list > DistroKit@pengutronix.de > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ DistroKit mailing list DistroKit@pengutronix.de