From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Mon, 1 Feb 2021 18:49:11 +0100 From: Robert Schwebel Message-ID: <20210201174911.ch5eb7pulnnfz2td@pengutronix.de> References: <20201206214817.15366-1-rhi@pengutronix.de> <20201206214817.15366-3-rhi@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201206214817.15366-3-rhi@pengutronix.de> Subject: Re: [DistroKit] [PATCH 3/3] rpi: image-boot-vfat: remove unused variables List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: distrokit-bounces@pengutronix.de Sender: "DistroKit" To: Roland Hieber Cc: distrokit@pengutronix.de On Sun, Dec 06, 2020 at 10:48:17PM +0100, Roland Hieber wrote: > The variables HEADER and START were apparently meant to be used as > replacements in configs/platform-rpi/config/images/boot-vfat.config, but > they are not used nowhere Furthermore, HEADER referenced a non-existent > file, START used the non-existing Kconfig symbol IMAGE_BOOT_VFAT_START, > and was not layer-aware by using PTXDIST_PLATFORMCONFIGDIR, and > start.elf is also already referenced in FILES. > > Signed-off-by: Roland Hieber > --- > configs/platform-rpi/rules/image-boot-vfat.make | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Applied, thx. rsc -- Pengutronix e.K. | Dipl.-Ing. Robert Schwebel | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 | _______________________________________________ DistroKit mailing list DistroKit@pengutronix.de