From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 01 Aug 2024 11:50:26 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sZSS2-0055dZ-0M for lore@lore.pengutronix.de; Thu, 01 Aug 2024 11:50:26 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sZSS1-0003Hq-3C; Thu, 01 Aug 2024 11:50:25 +0200 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sZSRu-0003HX-CA; Thu, 01 Aug 2024 11:50:18 +0200 Message-ID: <1d45ce6b-4bcf-4460-82b2-e2f5eaa37d6c@pengutronix.de> Date: Thu, 1 Aug 2024 11:50:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , distrokit@pengutronix.de References: <20240731223538.3008673-2-uwe@kleine-koenig.org> Content-Language: en-US From: Ahmad Fatoum In-Reply-To: <20240731223538.3008673-2-uwe@kleine-koenig.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [DistroKit] [PATCH v2] v7a: kernel: Enable I/O expander driver for STM32MP135F-DK X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hello Uwe, On 01.08.24 00:35, Uwe Kleine-König wrote: > From: Uwe Kleine-König Thanks for your patch. > > The i2c I/O expander MCP23S08 provides GPIOs to reset various components > (ethernet phy, display bridge, camera). The I/O expander is configured > as built-in as it is needed for nfs-root operation (once the kernel > contains the needed adaptions for the stmmac to support the stm32mp13x). > > Signed-off-by: Uwe Kleine-König Reviewed-by: Ahmad Fatoum Just a small nit below: > +CONFIG_PINCTRL_MCP23S08_I2C=y > +CONFIG_PINCTRL_MCP23S08_SPI=y Nit: We don't seem to actually need the SPI driver. Cheers, Ahmad > +CONFIG_PINCTRL_MCP23S08=y > # CONFIG_PINCTRL_MICROCHIP_SGPIO is not set > # CONFIG_PINCTRL_OCELOT is not set > # CONFIG_PINCTRL_PALMAS is not set > > base-commit: 747926d7f2936451c93f72b8dc0cfc58c7bb3122 -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |