From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 02 Jun 2023 18:41:16 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q57q2-007ZjQ-2u for lore@lore.pengutronix.de; Fri, 02 Jun 2023 18:41:16 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1q57pz-00024q-Ha; Fri, 02 Jun 2023 18:41:15 +0200 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1q57py-00024c-9J; Fri, 02 Jun 2023 18:41:14 +0200 Message-ID: <0a3a506d-d025-97ba-af59-b48300b0c561@pengutronix.de> Date: Fri, 2 Jun 2023 18:41:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Content-Language: en-US To: Michael Olbrich , distrokit@pengutronix.de References: <20230602145957.902307-1-m.olbrich@pengutronix.de> <20230602145957.902307-3-m.olbrich@pengutronix.de> From: Ahmad Fatoum In-Reply-To: <20230602145957.902307-3-m.olbrich@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [DistroKit] [PATCH 2/7] firmware-imx: move to the correct section X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On 02.06.23 16:59, Michael Olbrich wrote: > There is a non_free_firmware section, which is exactly for packages > like this. > > Signed-off-by: Michael Olbrich Reviewed-by: Ahmad Fatoum > --- > configs/platform-v8a/platformconfig | 8 ++++---- > configs/platform-v8a/rules/firmware-imx.in | 3 +-- > 2 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/configs/platform-v8a/platformconfig b/configs/platform-v8a/platformconfig > index 4e479660f6b7..7ac44a8777bd 100644 > --- a/configs/platform-v8a/platformconfig > +++ b/configs/platform-v8a/platformconfig > @@ -301,6 +301,10 @@ PTXCONF_HOST_M4=y > PTXCONF_HOST_OPENSSL=y > PTXCONF_HOST_SYSTEM_BC=y > PTXCONF_HOST_UTIL_LINUX=y > + > +# > +# non-free firmware blobs > +# > PTXCONF_FIRMWARE_IMX=y > # PTXCONF_FIRMWARE_IMX_VPU_IMX27 is not set > # PTXCONF_FIRMWARE_IMX_VPU_IMX51 is not set > @@ -308,10 +312,6 @@ PTXCONF_FIRMWARE_IMX=y > # PTXCONF_FIRMWARE_IMX_VPU_IMX6DL is not set > # PTXCONF_FIRMWARE_IMX_VPU_IMX6Q is not set > PTXCONF_FIRMWARE_IMX_BOOTIMAGE_IMX8=y > - > -# > -# non-free firmware blobs > -# > PTXCONF_FIRMWARE_ROCKCHIP=y > # PTXCONF_FIRMWARE_ROCKCHIP_RK3566_SDRAM is not set > PTXCONF_FIRMWARE_ROCKCHIP_RK3568_SDRAM=y > diff --git a/configs/platform-v8a/rules/firmware-imx.in b/configs/platform-v8a/rules/firmware-imx.in > index c756b963e5dc..8c76b693d257 100644 > --- a/configs/platform-v8a/rules/firmware-imx.in > +++ b/configs/platform-v8a/rules/firmware-imx.in > @@ -1,5 +1,4 @@ > -## SECTION=hosttools_platform > -# This should be in a firmware section, once we added that. > +## SECTION=non_free_firmware > > menuconfig FIRMWARE_IMX > tristate -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |